-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant ClusterManagerThrottlingMetricsCollector #582
Conversation
Signed-off-by: Khushboo Rajput <[email protected]>
Signed-off-by: Khushboo Rajput <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #582 +/- ##
============================================
+ Coverage 69.22% 69.28% +0.05%
+ Complexity 372 371 -1
============================================
Files 45 44 -1
Lines 2697 2689 -8
Branches 172 172
============================================
- Hits 1867 1863 -4
+ Misses 727 723 -4
Partials 103 103
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-582-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9e2b749d317d2cedd98b847f09c7f31f7c94c765
# Push it to GitHub
git push --set-upstream origin backport/backport-582-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
* Remove redundant ClusterManagerThrottlingMetricsCollector Signed-off-by: Khushboo Rajput <[email protected]> * Fix typo in ClusterManagerServiceEventMetrics Signed-off-by: Khushboo Rajput <[email protected]> --------- Signed-off-by: Khushboo Rajput <[email protected]> (cherry picked from commit 9e2b749)
* Remove redundant ClusterManagerThrottlingMetricsCollector Signed-off-by: Khushboo Rajput <[email protected]> * Fix typo in ClusterManagerServiceEventMetrics Signed-off-by: Khushboo Rajput <[email protected]> --------- Signed-off-by: Khushboo Rajput <[email protected]> (cherry picked from commit 9e2b749) Co-authored-by: Khushboo Rajput <[email protected]>
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
#514
Describe the solution you are proposing
Remove the redundant
ClusterManagerThrottlingMetricsCollector
, the throttling metrics are available via thestats
API.Additional context
More details available at opensearch-project/OpenSearch#479
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.