Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracer to getTransports #556

Merged

Conversation

Gaganjuneja
Copy link
Collaborator

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Fixing the breaking change - #555

Resolves - #555
Describe the solution you are proposing
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Gagan Juneja <[email protected]>
@Gaganjuneja
Copy link
Collaborator Author

@khushbr Need you help in reviewing this PR- This is breaking change introduced by telemetry instrumentation changes in the OpenSearch. It needs to go in 2.11 please take a look.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #556 (68a6fd1) into main (e7713ba) will not change coverage.
The diff coverage is n/a.

❗ Current head 68a6fd1 differs from pull request most recent head e910d0d. Consider uploading reports for the commit e910d0d to get more accurate results

@@            Coverage Diff            @@
##               main     #556   +/-   ##
=========================================
  Coverage     69.17%   69.17%           
  Complexity      371      371           
=========================================
  Files            45       45           
  Lines          2696     2696           
  Branches        172      172           
=========================================
  Hits           1865     1865           
  Misses          728      728           
  Partials        103      103           
Files Coverage Δ
...performanceanalyzer/PerformanceAnalyzerPlugin.java 76.92% <ø> (ø)

Copy link
Collaborator

@khushbr khushbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@khushbr khushbr merged commit 999c689 into opensearch-project:main Oct 5, 2023
3 of 5 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 5, 2023
Signed-off-by: Gagan Juneja <[email protected]>
Co-authored-by: Gagan Juneja <[email protected]>
(cherry picked from commit 999c689)
khushbr pushed a commit that referenced this pull request Oct 5, 2023
Signed-off-by: Gagan Juneja <[email protected]>
Co-authored-by: Gagan Juneja <[email protected]>
(cherry picked from commit 999c689)

Co-authored-by: Gagan Juneja <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants