[BugFix] wrapped http createContext in try/catch #565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atharvasharma61
requested review from
khushbr,
ansjcy,
sbcd90,
Shephalimittal,
nishchay21 and
rramachand21
as code owners
ansjcy
previously approved these changes
Jul 17, 2024
khushbr
reviewed
Jul 17, 2024
| @@ -17,7 +17,7 @@ public class Util { | |||
| private static final Logger LOG = LogManager.getLogger(Util.class); | |||
|
|
|||
| public static final String PA_BASE_URL = "/_plugins/_performanceanalyzer"; | |||
| public static final String LEGACY_OPENDISTRO_PA_BASE_URL = PA_BASE_URL; | |||
| public static final String LEGACY_OPENDISTRO_PA_BASE_URL = "/_opendistro/_performanceanalyzer"; | |||
There was a problem hiding this comment.
Is the _opendistro URL relevant for any versions of opensearch-project / performance-analyzer-rca ?
There was a problem hiding this comment.
We are not using it anywhere but we are maintaining it because we don't want to break any use-case if there exists any (
atharvasharma61
force-pushed
the
main
branch
from
b56706b
to
e3a84cc
Compare
|
@atharvasharma61 Hi, why did you close this PR? @ansjcy @khushbr Why didn't you tend to solve this bug? Why you leave an obvious bug not fix for a so long time? Unbelieveable! |
|
This was closed accidently after doing a force push in the main branch. Will raise a fresh PR again. Apologies! |
atharvasharma61
force-pushed
the
main
branch
from
b30b506
to
75579f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
resolved #545
Describe the solution you are proposing
httpServer.createContext throws illegalArgumentException when called more than once for same parameters. This commit ensures to avoid such scenarios in the PerformanceAnalyzerApp main class by fixing the legacy parameter. This commit also ensures that the RcaController thread gracefully handles the similar situation when RcaController thread is killed and respawned.
Describe alternatives you've considered
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.