Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[help wanted] test coverage for vital components #69

Open
kartva opened this issue Nov 22, 2023 · 2 comments
Open

[help wanted] test coverage for vital components #69

kartva opened this issue Nov 22, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@kartva
Copy link
Contributor

kartva commented Nov 22, 2023

Currently, the following test classes in the repository are lacking proper tests:

  • ThreadDiskIO.java
  • HeapMetricsTest.java
  • ThreadListTest.java
  • GCMetricsTest.java

Writing unit tests is a great way to become familiar with the codebase and offers a pathway to contributing to OpenSearch. Learning to write good tests is also valuable skill that you can develop by working on this issue.

For examples of current unit tests, you can have a look at #47 or #54.

If you would like to work on any of these, leave a comment on this issue with the name of the test so everyone knows you're working on it!
@kartva kartva added enhancement New feature or request untriaged labels Nov 22, 2023
@kartva kartva mentioned this issue Nov 22, 2023
Closed
@dblock dblock removed the untriaged label Jun 6, 2024
@dblock
Copy link
Member

dblock commented Jun 6, 2024

[Triage -- attendees 1, 2, 3, 4, 5, 6, 7]

@DesmondWillowbrook Any interest in adding the missing tests?

@kartva
Copy link
Contributor Author

kartva commented Jun 7, 2024 •
edited
Loading

I will not have any free time in the immediate future to work on this project. @dblock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dblock @kartva