Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Guides #162

Merged
Merged

Conversation

nhtruong
Copy link
Collaborator

@nhtruong nhtruong commented Mar 28, 2023

Description

Added API Guides

Issues Resolved

Part of opensearch-project/opensearch-clients#56

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@nhtruong nhtruong marked this pull request as draft March 29, 2023 15:49
@nhtruong nhtruong force-pushed the guides/document_lifecycle branch 2 times, most recently from 91b391d to 60b7e57 Compare April 3, 2023 17:44
@nhtruong nhtruong changed the title Document Lifecycle Guide API Guides Apr 3, 2023
@nhtruong nhtruong marked this pull request as ready for review April 4, 2023 15:45
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: use " vs. ' consistently in examples? Many strings use either.

@nhtruong
Copy link
Collaborator Author

nhtruong commented Apr 4, 2023

Nit: use " vs. ' consistently in examples? Many strings use either.

@dblock Do you mean this bit?

{ 
  "movies" => { 
    "aliases" => {}, 
    "mappings" => { 
        "properties" => { 
          "title" => { "type" => "text" }, 
          "year" => { "type" => "integer" },
          "director" => { "type" => "text" } 
        } 
    }, 
    "settings" => { 
      "index" => { 
        "creation_date" => "1680297372024", 
        "number_of_shards" => "2", 
        "number_of_replicas" => "0", 
        "uuid" => "FEDWXgmhSLyrCqWa8F_aiA", 
        "version" => { "created" => "136277827" }, 
        "provided_name" => "movies" 
      } 
    }
  } 
}

It's the output on the console that was copied-pasted as is.

@nhtruong nhtruong merged commit e45dd59 into opensearch-project:main Apr 4, 2023
@nhtruong nhtruong deleted the guides/document_lifecycle branch April 4, 2023 16:49
nhtruong added a commit to nhtruong/opensearch-ruby that referenced this pull request Apr 5, 2023
@nhtruong nhtruong mentioned this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants