Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Do not rely on import errors for async client imports #595

Open
dblock opened this issue Nov 16, 2023 · 0 comments
Open

[FEATURE] Do not rely on import errors for async client imports #595

dblock opened this issue Nov 16, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@dblock
Copy link
Member

dblock commented Nov 16, 2023

Is your feature request related to a problem?

In #594 I had to put back code that relies on errors for importing the async client. If iohttp is not available, an exception is raised and the async client is not imported.

What solution would you like?

A more reliable way to check for iohttp. There could be other errors during loading which are currently being lumped together. This potentially hides real bugs.

What alternatives have you considered?

Do nothing.

@dblock dblock added enhancement New feature or request untriaged Need triage and removed untriaged Need triage labels Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant