Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [2.x] Update Jackson to 2.14.0 (#258) #259

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

reta
Copy link
Collaborator

@reta reta commented Nov 8, 2022

Backport of #258 to 2.x

CHANGELOG.md Outdated
@@ -8,6 +8,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)

### Dependencies
- Bumps `grgit-gradle` from 4.0.1 to 5.0.0
- Update Jackson to 2.14.0 ([#258](https://github.com/opensearch-project/opensearch-java/pull/258))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be PR 259?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a backport but sure, I will update, thanks @VachaShah

Signed-off-by: Andriy Redko <[email protected]>

Signed-off-by: Andriy Redko <[email protected]>
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this 2.x branch again?

@dblock dblock merged commit a395e4f into opensearch-project:2.x Nov 9, 2022
@reta
Copy link
Collaborator Author

reta commented Nov 9, 2022

Why do we need this 2.x branch again?

Thanks @dblock, I think to align with 2.4 release?

@dblock
Copy link
Member

dblock commented Nov 9, 2022

But the client works against all the versions of OpenSearch doesn't it?

@reta
Copy link
Collaborator Author

reta commented Nov 9, 2022

But the client works against all the versions of OpenSearch doesn't it?

That is correct, but we moved 3.0 to Apache HttpClient 5.x and (due to #262) we will need 3.0.0 release to use the latest opensearch-java.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants