Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] TextEmbeddingProcessor has kind "inference" #1149

Closed
maxlepikhin opened this issue Aug 20, 2024 · 2 comments
Closed

[BUG] TextEmbeddingProcessor has kind "inference" #1149

maxlepikhin opened this issue Aug 20, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@maxlepikhin
Copy link

What is the bug?

TextEmbeddingProcessor has kind "inference".

How can one reproduce the bug?

See code.

What is the expected behavior?

Docs uses "text_embedding" kind.

What is your host/environment?

Ubuntu 22.04

Do you have any screenshots?

N/A

Do you have any additional context?

N/A

@maxlepikhin maxlepikhin added bug Something isn't working untriaged labels Aug 20, 2024
@Xtansia Xtansia removed the untriaged label Aug 27, 2024
@Xtansia
Copy link
Collaborator

Xtansia commented Aug 27, 2024

There's an open PR #1127 that will fix this.

Using new Processor.Builder().textEmbedding(...) will set the kind correctly:

            client.ingest()
                .putPipeline(
                    new PutPipelineRequest.Builder().id(INGEST_PIPELINE_NAME)
                        .description("A test_embedding ingest pipeline for the opensearch-java " + SAMPLE_NAME + " sample")
                        .processors(
                            new Processor.Builder().textEmbedding(
                                new TextEmbeddingProcessor.Builder().modelId(modelId).fieldMap("text", "passageEmbedding").build()
                            ).build()
                        )
                        .build()
                );

This issue only affects construction via new Processor(textEmbeddingProcessor).

@Xtansia
Copy link
Collaborator

Xtansia commented Oct 24, 2024

The fix for this was released in version 2.15.0

@Xtansia Xtansia closed this as completed Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants