Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add max_slices_per_pit to index settings operations #1130

Open
nwoike opened this issue Aug 6, 2024 · 1 comment
Open

[FEATURE] Add max_slices_per_pit to index settings operations #1130

nwoike opened this issue Aug 6, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@nwoike
Copy link

nwoike commented Aug 6, 2024

Is your feature request related to a problem?

The max_slices_per_pit index setting is completely missing from the index settings operations.

What solution would you like?

There should be an API similar to those for available for max_slices_per_scroll.

What alternatives have you considered?

I am able to configure this setting using the JavaScript client but that is not an option for this use-case.

Do you have any additional context?

APIs should look something like the following from client perspective.

val response = indices().getSettings(
    GetIndicesSettingsRequest
        .of { r -> r.index(index) }
)

response.result()[index]?.settings()?.maxSlicesPerPit()

indices().putSettings(
    PutIndicesSettingsRequest
        .of { p -> p.index(index).settings { s -> s.maxSlicesPerPit(maxSliceCount) } }
)

@nwoike nwoike added enhancement New feature or request untriaged labels Aug 6, 2024
@dblock
Copy link
Member

dblock commented Aug 6, 2024

Thanks. FYI we're also working on generating this code from spec in #366, appreciate if you could contribute the missing setting(s) to https://github.com/opensearch-project/opensearch-api-specification.

@Xtansia Xtansia removed the untriaged label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants