Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows Container] Switch windows docker jdk back to temurin/openjdk mix #3946

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Aug 31, 2023

Description

[Windows Container] Switch windows docker jdk back to temurin/openjdk mix

Issues Resolved

opensearch-project/opensearch-ci#281
#3743

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #3946 (830abb9) into main (f9077fa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3946   +/-   ##
=======================================
  Coverage   92.05%   92.05%           
=======================================
  Files         187      187           
  Lines        5667     5667           
=======================================
  Hits         5217     5217           
  Misses        450      450           

@peterzhuamazon peterzhuamazon merged commit f6c1279 into opensearch-project:main Aug 31, 2023
13 checks passed
@peterzhuamazon peterzhuamazon deleted the docker-windows-switch-jdk-again-mix branch August 31, 2023 17:02
@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Aug 31, 2023

$jdkVersionList = "openjdk8-redhat JAVA8_HOME", "openjdk11 JAVA11_HOME", "openjdk14 JAVA14_HOME", "openjdk17 JAVA17_HOME", "openjdk19 JAVA19_HOME", "openjdk20 JAVA20_HOME"
# As of now we will mix temurin and openjdk as temurin for production has support policies for fixes and patches
# We need to make sure we do not mis-install temurin and openjdk with the same version or the distribution build code will have issues
$jdkVersionList = "temurin8-jdk JAVA8_HOME", "temurin11-jdk JAVA11_HOME", "openjdk14 JAVA14_HOME", "temurin17-jdk JAVA17_HOME", "temurin19-jdk JAVA19_HOME", "openjdk20 JAVA20_HOME"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@peterzhuamazon peterzhuamazon changed the title Switch windows docker jdk back to temurin/openjdk mix [Windows Container] Switch windows docker jdk back to temurin/openjdk mix Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants