-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Lucene snapshot from custom repository to artifacts.opensearch.org #3874
Comments
+1 |
Hey! I believe ci.opensearch.org is a better choice. We eventually want to move https://artifacts.opensearch.org/snapshots/ to ci.opensearch.org/snapshots too. Will take a look into integrating it. Thanks! |
I want to mention that apart from moving the snapshot, we also need to start a campaign to make sure repos that use that snapshot will have the new url. Ex: https://github.com/opensearch-project/ml-commons/blob/main/build.gradle#L33 |
Just talked with @mch2 on this and get the latest status. Thanks. |
We've seen build & test failures [1] from the current hosting setup - 🤞 this change would improve the support and stability. |
Start looking at the setups to add a new role for the syncing. |
Able to connect to my own s3 bucket and also improve the github workflow more. Thanks. |
@mch2 will take care of the dependencies update once the link is available. |
All backend setups are completed now. |
Old snapshots are synced to new bucket now. |
With PR merged now I think @mch2 will start testing both after publishing a new snapshot. |
New location: https://ci.opensearch.org/ci/dbc/snapshots/lucene/ |
Hi @mch2 we are closing this issue as Infra task is completed, please open another issue if you want to track changing urls. Thanks. |
- Related opensearch-project/opensearch-build#3874 Signed-off-by: Peter Nied <[email protected]>
- Related opensearch-project/opensearch-build#3874 Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]>
- Related opensearch-project/opensearch-build#3874 - Related opensearch-project/OpenSearch#11728 Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]>
* Switched to more reliable OpenSearch Lucene snapshot location - Related opensearch-project/opensearch-build#3874 Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> * Changelog entry Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> --------- Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]>
…ation (opensearch-project#11728) * Switched to more reliable OpenSearch Lucene snapshot location - Related opensearch-project/opensearch-build#3874 (cherry picked from commit 16d457d) Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]>
…ation (#11728) (#11729) * Switched to more reliable OpenSearch Lucene snapshot location - Related opensearch-project/opensearch-build#3874 (cherry picked from commit 16d457d) Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]>
* Switched to more reliable OpenSearch Lucene snapshot location - Related opensearch-project/opensearch-build#3874 Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> * Changelog entry Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> * Use required-approval@main * Trigger on any review Signed-off-by: Peter Nied <[email protected]> * Snap to version v1.3 Signed-off-by: Peter Nied <[email protected]> --------- Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]>
* Switched to more reliable OpenSearch Lucene snapshot location - Related opensearch-project/opensearch-build#3874 Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> * Changelog entry Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> * Use required-approval@main * Trigger on any review Signed-off-by: Peter Nied <[email protected]> * Snap to version v1.3 Signed-off-by: Peter Nied <[email protected]> --------- Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> (cherry picked from commit 3f5ec64) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Switched to more reliable OpenSearch Lucene snapshot location - Related opensearch-project/opensearch-build#3874 * Changelog entry * Use required-approval@main * Trigger on any review * Snap to version v1.3 --------- (cherry picked from commit 3f5ec64) Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
- Related opensearch-project/opensearch-build#3874 - Related opensearch-project/OpenSearch#11728 Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> Co-authored-by: Owais Kazi <[email protected]>
- Related opensearch-project/opensearch-build#3874 - Related opensearch-project/OpenSearch#11728 Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> Co-authored-by: Owais Kazi <[email protected]> (cherry picked from commit 95f0eaf) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
) - Related opensearch-project/opensearch-build#3874 - Related opensearch-project/OpenSearch#11728 (cherry picked from commit 95f0eaf) Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Owais Kazi <[email protected]> Co-authored-by: Sarat Vemulapalli <[email protected]>
Hi @peternied @owaiskazi19 @mch2 : Recently I have noticed you updated a lot of the lucene snapshots url. Would you mind correct this url in all repos affected so repos can correctly consume the changes. Thanks! |
Issues: - Driver of this change opensearch-project/opensearch-build#3874 (comment) - Previous change updated the wrong location opensearch-project#11728 Signed-off-by: Peter Nied <[email protected]>
…ch-project#11728) * Switched to more reliable OpenSearch Lucene snapshot location - Related opensearch-project/opensearch-build#3874 Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> * Changelog entry Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> --------- Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]>
…t#11820) * Switched to more reliable OpenSearch Lucene snapshot location - Related opensearch-project/opensearch-build#3874 Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> * Changelog entry Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> * Use required-approval@main * Trigger on any review Signed-off-by: Peter Nied <[email protected]> * Snap to version v1.3 Signed-off-by: Peter Nied <[email protected]> --------- Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]>
…ch-project#11728) * Switched to more reliable OpenSearch Lucene snapshot location - Related opensearch-project/opensearch-build#3874 Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> * Changelog entry Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> --------- Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
…t#11820) * Switched to more reliable OpenSearch Lucene snapshot location - Related opensearch-project/opensearch-build#3874 Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> * Changelog entry Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> * Use required-approval@main * Trigger on any review Signed-off-by: Peter Nied <[email protected]> * Snap to version v1.3 Signed-off-by: Peter Nied <[email protected]> --------- Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Is your feature request related to a problem? Please describe
Today OpenSearch hosts snapshot versions of Lucene at
repo.setUrl("https://d1nvenhzbhpy0q.cloudfront.net/snapshots/lucene/");
. These snapshot versions are used to build/test against unreleased versions of Lucene on main & 2.x example. This extra url is a bit sloppy, confusing and requires extra management when we already have a url for artifacts. It would be great to host these instead under thehttps://artifacts.opensearch.org/snapshots
orci.opensearch.org
umbrella.Describe the solution you'd like
Create a repository under https://artifacts.opensearch.org/snapshots/lucene to host the snapshots. I think all that would be required here is a new path?
For context the existing repo was set up using the https://github.com/opensearch-project/data-prepper/tree/main/release/staging-resources-cdk.
The workflow pushing built snapshots is here. All that would need to change there is the bucket/role used.
Describe alternatives you've considered
Leaving as is.
Additional context
After this is created we can update the WF to push to the new bucket (or both temporarily), update RepositoriesSetupPlugin and any downstream using the old url directly.
Acceptance Criteria
Lucene Snapshots should be downloaded from ci.opensearch.org
The text was updated successfully, but these errors were encountered: