-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade CMake to version: 3.23.3 #3706
Comments
@peterzhuamazon will take a look this , most likey it may be pushed to after 2.9.0, but Peter will provide more insights of it .. thanks ... here is a link to it for the reference .. #1563. |
Hi @bbarani @prudhvigodithi I will take care of this per our discussion. @navneet1v We will see if we can get all the images ready by eod tomorrow. Thanks. |
The code change from k-nn is merged in 2.x branch. The build might start to fail now. Can we prioritize the 2.9 release distributions first |
Hi @navneet1v this is a last minute change and we are working on it already. |
This task is complete by now. |
As part of upgrading the downstream libraries in K-NN to add the support for filtering[https://github.com/opensearch-project/k-NN/pull/942], we need to upgrade the CMake version otherwise builds for the K-NN Native Libraries will start to fail. The ask for the issue to upgrade the Cmake version to 3.23.3.
Places to change:
A simple search of Cmake in build repo these many places where changes needs to be done: https://github.com/search?q=repo%3Aopensearch-project%2Fopensearch-build%20cmake&type=code
Can you provide what is the best way to make these changes? Can this change be picked by the Build team?
Once the CMake is upgraded I will start to merge the PR in 2.x branch otherwise the build for 2.x will start to fail
The text was updated successfully, but these errors were encountered: