Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CMake to version: 3.23.3 #3706

Closed
navneet1v opened this issue Jul 6, 2023 · 7 comments
Closed

Upgrade CMake to version: 3.23.3 #3706

navneet1v opened this issue Jul 6, 2023 · 7 comments
Assignees
Labels
cicd dependencies Pull requests that update a dependency file enhancement New Enhancement jenkins Jenkins related issue release v2.9.0

Comments

@navneet1v
Copy link
Contributor

As part of upgrading the downstream libraries in K-NN to add the support for filtering[https://github.com/opensearch-project/k-NN/pull/942], we need to upgrade the CMake version otherwise builds for the K-NN Native Libraries will start to fail. The ask for the issue to upgrade the Cmake version to 3.23.3.

Places to change:
A simple search of Cmake in build repo these many places where changes needs to be done: https://github.com/search?q=repo%3Aopensearch-project%2Fopensearch-build%20cmake&type=code

Can you provide what is the best way to make these changes? Can this change be picked by the Build team?

Once the CMake is upgraded I will start to merge the PR in 2.x branch otherwise the build for 2.x will start to fail

@jordarlu
Copy link
Contributor

@peterzhuamazon will take a look this , most likey it may be pushed to after 2.9.0, but Peter will provide more insights of it .. thanks ... here is a link to it for the reference .. #1563.

@jordarlu jordarlu removed the untriaged Issues that have not yet been triaged label Jul 10, 2023
@navneet1v
Copy link
Contributor Author

navneet1v commented Jul 10, 2023

@bbarani @jordarlu this needs to go in 2.9. There are changes in k-NN plugin that requires this.

@peterzhuamazon peterzhuamazon self-assigned this Jul 10, 2023
@peterzhuamazon peterzhuamazon added release cicd docker jenkins Jenkins related issue dependencies Pull requests that update a dependency file and removed v3.0.0 labels Jul 10, 2023
@peterzhuamazon
Copy link
Member

Hi @bbarani @prudhvigodithi I will take care of this per our discussion.

@navneet1v We will see if we can get all the images ready by eod tomorrow.

Thanks.

@navneet1v
Copy link
Contributor Author

The code change from k-nn is merged in 2.x branch. The build might start to fail now. Can we prioritize the 2.9 release distributions first

@peterzhuamazon
Copy link
Member

Hi @navneet1v this is a last minute change and we are working on it already.
Thanks.

@peterzhuamazon
Copy link
Member

This task is complete by now.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cicd dependencies Pull requests that update a dependency file enhancement New Enhancement jenkins Jenkins related issue release v2.9.0
Projects
Development

No branches or pull requests

3 participants