Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for SplitResponseProcessor #526

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

dbwiddis
Copy link
Member

@dbwiddis dbwiddis commented Aug 23, 2024

Description

Adds a test exercising the SplitResponseProcessor, re-enabled in 2.17:

Issues Resolved

Continuation of #440 superceded by #505

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

github-actions bot commented Aug 23, 2024

Changes Analysis

Commit SHA: e951787
Comparing To SHA: 5d2b36c

API Changes

Summary

NO CHANGES

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10564269114/artifacts/1855674621

API Coverage

Before After Δ
Covered (%) 533 (52.2 %) 533 (52.2 %) 0 (0 %)
Uncovered (%) 488 (47.8 %) 488 (47.8 %) 0 (0 %)
Unknown 26 26 0

@dbwiddis
Copy link
Member Author

dbwiddis commented Aug 23, 2024

🐔 Failing test pending merge and backport of PR linked above
🥚 opening this PR is a prerequisite for merging that one

ERROR RESPONSE STATUS (Expected status 200, but received 400: application/json. Invalid processor type split)

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged the linked PR.

CHANGELOG.md Outdated Show resolved Hide resolved
dblock
dblock previously approved these changes Aug 24, 2024
@dbwiddis
Copy link
Member Author

Still failing because workflow spec files don't match current

@dblock
Copy link
Member

dblock commented Aug 26, 2024

Still failing because workflow spec files don't match current

You should update the sha in this PR.

Copy link

Spec Test Coverage Analysis

Total Tested
559 368 (65.83 %)

@dblock dblock merged commit 3a9caa7 into opensearch-project:main Aug 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants