Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Metadata schema. #399

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Fix: Metadata schema. #399

merged 1 commit into from
Jul 11, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Jul 10, 2024

Description

Fixes _meta in various places. Currently the following doesn't work because it wants description to also be an object.

_meta:
  description: xyz

Adds tests for index and component templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock changed the title Fix: _meta request format. Fix: _meta request schema. Jul 10, 2024
@dblock dblock changed the title Fix: _meta request schema. Fix: _meta schema. Jul 10, 2024
@dblock dblock changed the title Fix: _meta schema. Fix: Metadata schema. Jul 10, 2024
@dblock dblock force-pushed the index-component-templates branch from eae12aa to a0cb77e Compare July 10, 2024 20:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

Changes Analysis

Commit SHA: a0cb77e
Comparing To SHA: 046b7d1

API Changes

Summary


└─┬Components
  └─┬_common:Metadata
    └──[🔀] additionalProperties (26725:29)❌
Document Element Total Changes Breaking Changes
components 1 1
  • ❌ BREAKING Changes: 1 out of 1
  • Modifications: 1
  • Breaking Modifications: 1

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9881233989/artifacts/1688374466

API Coverage

Before After Δ
Covered (%) 483 (47.31 %) 483 (47.31 %) 0 (0 %)
Uncovered (%) 538 (52.69 %) 538 (52.69 %) 0 (0 %)
Unknown 24 24 0

@Xtansia Xtansia merged commit fd96e3e into opensearch-project:main Jul 11, 2024
8 checks passed
@dblock dblock deleted the index-component-templates branch July 11, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xtansia Xtansia Xtansia approved these changes

@harshavamsi harshavamsi Awaiting requested review from harshavamsi harshavamsi is a code owner

@sachetalva sachetalva Awaiting requested review from sachetalva sachetalva is a code owner

@nhtruong nhtruong Awaiting requested review from nhtruong nhtruong is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@Tokesh Tokesh Awaiting requested review from Tokesh Tokesh is a code owner

@aabeshov aabeshov Awaiting requested review from aabeshov aabeshov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dblock @Xtansia