Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add specs for search processors #507

Open
Tracked by #168
dblock opened this issue Aug 13, 2024 · 3 comments
Open
Tracked by #168

[FEATURE] Add specs for search processors #507

dblock opened this issue Aug 13, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@dblock
Copy link
Member

dblock commented Aug 13, 2024

Is your feature request related to a problem?

OpenSearch supports a number of search request/response processors. Tests tests were added in #505.

What solution would you like?

Add specs and tests for the remaining processors.

Do you have any additional context?

Part of #168.

@dblock dblock added enhancement New feature or request untriaged labels Aug 13, 2024
@dbwiddis dbwiddis self-assigned this Aug 13, 2024
@dblock dblock removed the untriaged label Aug 13, 2024
@Tokesh
Copy link
Collaborator

Tokesh commented Aug 25, 2024

Hello :)
As I understand it, all that remains from the specs is to add ml_inference, neural_sparse_two_phase_processor and tests for them?

@dbwiddis
Copy link
Member

As I understand it, all that remains from the specs ...

There should be tests written to cover as many of the processors as possible as well; these do not yet exist and were what I was planning on doing when I self-assigned.

I'm not sure which namespace we should use for plugin-added processors which may or may not be available.

@navneet1v
Copy link

@dblock adding to the scope of this issue, Opensearch also supports SearchPhaseResults Processors. So when we pick this GH issue lets ensure that we are picking up spec for PhaseResultsProcessors too. Ref: https://opensearch.org/docs/latest/search-plugins/search-pipelines/normalization-processor/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants