Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add specs for knn namespace #226

Open
5 tasks
Tracked by #168
nhtruong opened this issue Apr 11, 2024 · 4 comments
Open
5 tasks
Tracked by #168

[FEATURE] Add specs for knn namespace #226

nhtruong opened this issue Apr 11, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@nhtruong
Copy link
Collaborator

Part of Adding missing API specs issue

  • /_opendistro/_knn/stats/: ["GET"]
  • /_opendistro/_knn/stats/{stat}: ["GET"]
  • /_opendistro/_knn/warmup/{index}: ["GET"]
  • /_opendistro/_knn/{nodeId}/stats/: ["GET"]
  • /_opendistro/_knn/{nodeId}/stats/{stat}: ["GET"]
@nhtruong nhtruong added enhancement New feature or request untriaged and removed untriaged labels Apr 11, 2024
@nhtruong
Copy link
Collaborator Author

@vamshin @navneet1v, Would you mind assigning this Issue to the appropriate person? Thank you.

@navneet1v
Copy link

@nhtruong based on this comment from @dblock do we still need to add api specs for these urls?

@dblock
Copy link
Member

dblock commented Apr 16, 2024

I should probably take that back, what's the correct way to add and mark these deprecated? And is there a way to provide aliases since these are identical to other _knn APIs?

@nhtruong
Copy link
Collaborator Author

Just responded #168 (comment)

@navneet1v, if these endpoints are identical to the _plugins counterparts (minus the fact they are deprecated), then our tools will handle it. If not, you'll have to redefine them. For this ticket, would you mind going over the _plugins/knn/ endpoints to make sure that they are correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants