Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL] Reduce the number of approvers required in this repo to 1 #199

Closed
dblock opened this issue Mar 12, 2024 · 7 comments
Closed

[PROPOSAL] Reduce the number of approvers required in this repo to 1 #199

dblock opened this issue Mar 12, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@dblock
Copy link
Member

dblock commented Mar 12, 2024

What/Why

What are you proposing?

Currently the number of approvers required to merge a CR in this repo is 2.

What problems are you trying to solve?

This affects velocity unnecessarily. This repo doesn't have production impact and any potential mistake is easily undone.

Screenshot 2024-03-12 at 3 54 13 PM

What is the developer experience going to be?

Only 1 approver required instead of 2 for PRs.

What will it take to execute?

If a majority of existing maintainers can +1 I'll lower this number.

@dblock dblock added the enhancement New feature or request label Mar 12, 2024
@dblock
Copy link
Member Author

dblock commented Mar 12, 2024

@Xtansia
Copy link
Collaborator

Xtansia commented Mar 12, 2024

I'm in support of doing this 👍

@Xtansia Xtansia removed the untriaged label Mar 12, 2024
@dblock
Copy link
Member Author

dblock commented Mar 12, 2024

@abhivka7 do you have an alternate email? drop me a note to dblock[at]amazon[dot]com.

@nhtruong
Copy link
Collaborator

I'm in!

@VachaShah
Copy link
Collaborator

I am in!

@sachetalva
Copy link
Collaborator

👍

@dblock
Copy link
Member Author

dblock commented Mar 14, 2024

Looks like we have majority of maintainers agreeing to this, I made the change.

@dblock dblock closed this as completed Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants