Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update jdk version to 21 in maven publish workflow #837

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

yuye-aws
Copy link
Member

@yuye-aws yuye-aws commented Jul 19, 2024

Description

Update jdk version to 21 in maven publish workflow to fix test: https://github.com/opensearch-project/neural-search/actions/runs/10005385653/job/27655990133

Issues Resolved

Update jdk version to 21 in maven publish workflow to fix test: https://github.com/opensearch-project/neural-search/actions/runs/10005385653/job/27655990133

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@yuye-aws
Copy link
Member Author

ml-commons have similar PR: opensearch-project/ml-commons#2625

Signed-off-by: yuye-aws <[email protected]>
@zhichao-aws zhichao-aws merged commit 235dfe3 into opensearch-project:main Jul 19, 2024
33 checks passed
@navneet1v
Copy link
Collaborator

Thanks @yuye-aws for making this change. Can we fix all other CIs too.?

@yuye-aws
Copy link
Member Author

@navneet1v What other CIs need to fix?

@navneet1v
Copy link
Collaborator

I think everything is fixed now after pr from reta.

@yuye-aws yuye-aws deleted the Fix/MavenPublish branch September 10, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants