Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport main] Added Multimodal semantic search feature #434

Conversation

martin-gaievski
Copy link
Member

@martin-gaievski martin-gaievski commented Oct 11, 2023

Upport Multimodal search support (#359) from 2.x 841f280 to main

Check List

  • All tests pass
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Adding inference processor and factory, register that in plugin class

Signed-off-by: Martin Gaievski <[email protected]>
(cherry picked from commit 841f280)
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #434 (60c4f69) into main (0f73cc6) will decrease coverage by 0.20%.
The diff coverage is 82.66%.

❗ Current head 60c4f69 differs from pull request most recent head 801327d. Consider uploading reports for the commit 801327d to get more accurate results

@@             Coverage Diff              @@
##               main     #434      +/-   ##
============================================
- Coverage     84.56%   84.37%   -0.20%     
- Complexity      449      498      +49     
============================================
  Files            38       40       +2     
  Lines          1348     1491     +143     
  Branches        201      228      +27     
============================================
+ Hits           1140     1258     +118     
- Misses          120      133      +13     
- Partials         88      100      +12     
Files Coverage Δ
...g/opensearch/neuralsearch/plugin/NeuralSearch.java 72.72% <100.00%> (+1.29%) ⬆️
...pensearch/neuralsearch/processor/NLPProcessor.java 92.71% <100.00%> (ø)
...ocessor/factory/TextEmbeddingProcessorFactory.java 100.00% <100.00%> (ø)
...or/factory/TextImageEmbeddingProcessorFactory.java 100.00% <100.00%> (ø)
...earch/neuralsearch/ml/MLCommonsClientAccessor.java 94.28% <93.10%> (-0.59%) ⬇️
...nsearch/neuralsearch/query/NeuralQueryBuilder.java 88.88% <83.33%> (ø)
...lsearch/processor/TextImageEmbeddingProcessor.java 78.43% <78.43%> (ø)

@martin-gaievski martin-gaievski changed the title Backport/backport 359 to main [Backport main] Added Multimodal semantic search feature Oct 11, 2023
@martin-gaievski martin-gaievski added the Features Introduces a new unit of functionality that satisfies a requirement label Oct 11, 2023
Signed-off-by: Martin Gaievski <[email protected]>
@martin-gaievski martin-gaievski merged commit 04c1e05 into opensearch-project:main Oct 11, 2023
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Features Introduces a new unit of functionality that satisfies a requirement skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants