Fixed error for case when mltensor has data as null #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-gaievski
added
skip-changelog
backport 2.11
v2.11.0
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
fix_empty_data_in_mltensor
branch
from
18b95ed
to
e592ad7
Compare
Codecov Report
@@ Coverage Diff @@
## 2.x #404 +/- ##
============================================
- Coverage 80.69% 80.67% -0.03%
- Complexity 496 501 +5
============================================
Files 41 41
Lines 1554 1573 +19
Branches 237 241 +4
============================================
+ Hits 1254 1269 +15
- Misses 200 201 +1
- Partials 100 103 +3
|
heemin32
approved these changes
Oct 6, 2023
martin-gaievski
requested review from
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
sean-zheng-amazon,
model-collapse,
wujunshen,
zane-neo,
ylwu-amzn and
jngz-es
as code owners
navneet1v
reviewed
Oct 6, 2023
| @@ -40,6 +42,7 @@ | |||
| public class MLCommonsClientAccessor { | |||
| private static final List<String> TARGET_RESPONSE_FILTERS = List.of("sentence_embedding"); | |||
| private final MachineLearningNodeClient mlClient; | |||
| private static final String EXCEPTION_MESSAGE_MODEL_PROCESSING_FAILED = "the system encountered an unexpected error during processing"; | |||
There was a problem hiding this comment.
we need to fix this, lets make it more informative.
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
fix_empty_data_in_mltensor
branch
from
9f46960
to
5f47156
Compare
navneet1v
approved these changes
Oct 6, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 6, 2023
* Fixed error for case when mltensor has data as null Signed-off-by: Martin Gaievski <[email protected]> * Changed error message handling Signed-off-by: Martin Gaievski <[email protected]> --------- Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 47d1aee)
navneet1v
pushed a commit
that referenced
this pull request
Oct 6, 2023
* Fixed error for case when mltensor has data as null Signed-off-by: Martin Gaievski <[email protected]> * Changed error message handling Signed-off-by: Martin Gaievski <[email protected]> --------- Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 47d1aee) Co-authored-by: Martin Gaievski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found that we're not handling properly case when MLTensor has data ==
nullfrom model/connector onpredictcall. Need to throw proper exception in that caseCheck List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.