Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compilation errors after refactoring in core Strings class #243

Merged

Conversation

martin-gaievski
Copy link
Member

Description

Fixed compilation errors after changes in core Strings classes (core PR)

Check List

  • All tests pass
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@martin-gaievski martin-gaievski added backport 2.x Label will add auto workflow to backport PR to 2.x branch skip-changelog labels Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #243 (2e45f32) into main (61e6e98) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #243   +/-   ##
=========================================
  Coverage     86.23%   86.23%           
  Complexity      337      337           
=========================================
  Files            28       28           
  Lines           981      981           
  Branches        153      153           
=========================================
  Hits            846      846           
  Misses           69       69           
  Partials         66       66           

@martin-gaievski martin-gaievski merged commit b9c86a8 into main Aug 7, 2023
41 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-243-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b9c86a817e7c2b421430624ea629fcc8908da374
# Push it to GitHub
git push --set-upstream origin backport/backport-243-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-243-to-2.x.

navneet1v pushed a commit to navneet1v/neural-search that referenced this pull request Aug 17, 2023
navneet1v added a commit that referenced this pull request Aug 17, 2023
….x branch (#253)

* Fixed compilation errors after refactoring in core (#249)

Signed-off-by: Martin Gaievski <[email protected]>

* Fixing test classes after core refactoring (#237)

Signed-off-by: Martin Gaievski <[email protected]>

* Fixed compilation errors after refactoring in core Strings class (#243)

Signed-off-by: Martin Gaievski <[email protected]>

* Switch from XContentType to MediaType to fix compilation errors (#232)

Signed-off-by: Martin Gaievski <[email protected]>

* Fixing the Media type being not able to be read from Headers.

Signed-off-by: Navneet Verma <[email protected]>

---------

Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Navneet Verma <[email protected]>
Co-authored-by: Martin Gaievski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Label will add auto workflow to backport PR to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants