Address Naveen's comment

Signed-off-by: Varun Jain <[email protected]>
opensearch-project · Aug 21, 2024 · 4c93548 · 4c93548
1 parent 7799975
commit 4c93548
Showing 1 changed file with 2 additions and 15 deletions.
diff --git a/src/main/java/org/opensearch/neuralsearch/ml/MLCommonsClientAccessor.java b/src/main/java/org/opensearch/neuralsearch/ml/MLCommonsClientAccessor.java
@@ -16,6 +16,7 @@
 import java.util.stream.Collectors;
 
 import org.opensearch.core.action.ActionListener;
+import org.opensearch.core.common.Strings;
 import org.opensearch.core.common.util.CollectionUtils;
 import org.opensearch.ml.client.MachineLearningNodeClient;
 import org.opensearch.ml.common.FunctionName;
@@ -236,7 +237,7 @@ private List<List<Float>> buildVectorFromResponse(MLOutput mlOutput) {
             final List<ModelTensor> tensorsList = tensors.getMlModelTensors();
             for (final ModelTensor tensor : tensorsList) {
                 if (Objects.isNull(tensor.getData())) {
-                    if (Objects.nonNull(tensor.getDataAsMap()) && checkIfStringIsNotBlank((String) tensor.getDataAsMap().get("message"))) {
+                    if (Objects.nonNull(tensor.getDataAsMap()) && Strings.hasText((String) tensor.getDataAsMap().get("message"))) {
                         String errorFromModel = (String) tensor.getDataAsMap().get("message");
                         throw new IllegalStateException(
                             String.format(Locale.ROOT, "%s: %s", EXCEPTION_MESSAGE_PREFIX_MODEL_PREDICT_FAILED, errorFromModel)
@@ -310,18 +311,4 @@ private MLInput createMLMultimodalInput(final List<String> targetResponseFilters
         final MLInputDataset inputDataset = new TextDocsInputDataSet(inputText, modelResultFilter);
         return new MLInput(FunctionName.TEXT_EMBEDDING, null, inputDataset);
     }
-
-    private boolean checkIfStringIsNotBlank(String value) {
-        if (value == null || value.isEmpty()) {
-            return false;
-        }
-        // returns true when the String even contain a single character which is not a white space.
-        for (int i = 0; i < value.length(); ++i) {
-            char c = value.charAt(i);
-            if (!Character.isWhitespace(c)) {
-                return true;
-            }
-        }
-        return false;
-    }
 }