Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cross encoder support #1615

Merged
merged 18 commits into from
Dec 7, 2023
Merged

Add cross encoder support #1615

merged 18 commits into from
Dec 7, 2023

Commits on Nov 29, 2023

  1. add text similarity inputs and function name 

    Signed-off-by: HenryL27 <[email protected]>
    @HenryL27
    HenryL27 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    3e9526b View commit details
    Browse the repository at this point in the history

  2. add text similarity cross encoder model 

    Signed-off-by: HenryL27 <[email protected]>
    @HenryL27
    HenryL27 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    a840ae7 View commit details
    Browse the repository at this point in the history

  3. add text similarity unit tests 

    Signed-off-by: HenryL27 <[email protected]>
    @HenryL27
    HenryL27 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    3734ac4 View commit details
    Browse the repository at this point in the history

  4. add text similarity input unittests 

    Signed-off-by: HenryL27 <[email protected]>
    @HenryL27
    HenryL27 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    2ffea39 View commit details
    Browse the repository at this point in the history

  5. add text similarity dataset unittests 

    Signed-off-by: HenryL27 <[email protected]>
    @HenryL27
    HenryL27 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    a03e7ce View commit details
    Browse the repository at this point in the history

  6. add function name annotation 

    Signed-off-by: HenryL27 <[email protected]>
    @HenryL27
    HenryL27 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    15e81bc View commit details
    Browse the repository at this point in the history

  7. refactor API to use single query 

    Signed-off-by: HenryL27 <[email protected]>
    @HenryL27
    HenryL27 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    8dce6a9 View commit details
    Browse the repository at this point in the history

  8. omit private from class vars 

    Co-authored-by: Navneet Verma <[email protected]>
Signed-off-by: HenryL27 <[email protected]>
    @HenryL27 @navneet1v
    HenryL27 and navneet1v committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    7871d8c View commit details
    Browse the repository at this point in the history

  9. change output name from logits to similarity 

    Signed-off-by: HenryL27 <[email protected]>
    @HenryL27
    HenryL27 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    26bcbcd View commit details
    Browse the repository at this point in the history

  10. hashify isDLModel 

    Signed-off-by: HenryL27 <[email protected]>
    @HenryL27
    HenryL27 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    c32cf9e View commit details
    Browse the repository at this point in the history

  11. add error message for non-torchscript cross encoders 

    Signed-off-by: HenryL27 <[email protected]>
    @HenryL27
    HenryL27 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    0fc9028 View commit details
    Browse the repository at this point in the history

  12. allow onnx, actually. 

    Signed-off-by: HenryL27 <[email protected]>
    @HenryL27
    HenryL27 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    4ea18fa View commit details
    Browse the repository at this point in the history

  13. apply spotless after rebase 

    Signed-off-by: HenryL27 <[email protected]>
    @HenryL27
    HenryL27 committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    9d4e083 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. add unittest for new mlinput toXcontent clause 

    Signed-off-by: HenryL27 <[email protected]>
    @HenryL27
    HenryL27 committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    6d7b429 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. static DLModels 

    Signed-off-by: HenryL27 <[email protected]>
    @HenryL27
    HenryL27 committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    97e10b1 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. add tests and error message tweaks 

    Signed-off-by: HenryL27 <[email protected]>
    @HenryL27
    HenryL27 committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    09e0f91 View commit details
    Browse the repository at this point in the history

  2. name test models w framework 

    Signed-off-by: HenryL27 <[email protected]>
    @HenryL27
    HenryL27 committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    b3e90b5 View commit details
    Browse the repository at this point in the history

  3. change pt->torch_script 

    Signed-off-by: HenryL27 <[email protected]>
    @HenryL27
    HenryL27 committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    be113ed View commit details
    Browse the repository at this point in the history