Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support local cross-encoder model #1589

Open
HenryL27 opened this issue Nov 3, 2023 · 5 comments
Open

[FEATURE] Support local cross-encoder model #1589

HenryL27 opened this issue Nov 3, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request v2.12.0 Issues targeting release v2.12.0

Comments

@HenryL27
Copy link
Collaborator

HenryL27 commented Nov 3, 2023

Is your feature request related to a problem?
We're trying to put a bunch of local model types in ml-commons (#1164). One such type is a cross-encoder. This will allow us to support reranking in the neural-search plugin, which a lot of people have asked for.

What solution would you like?
Will be able to upload a custom cross-encoder model, deploy it, and use it with the upcoming neural search reranking processor.

What alternatives have you considered?
External hosting: Still would have to deal with the inputs and outputs, and then we also get the pleasure of figuring out some solution for externally hosting cross-encoders.

LTR: That can do reranking, but not cross-encoder reranking, so this isn't where that thought belongs.

Do you have any additional context?
Add any other context or screenshots about the feature request here.

@HenryL27 HenryL27 added enhancement New feature or request untriaged labels Nov 3, 2023
@HenryL27 HenryL27 self-assigned this Nov 3, 2023
@HenryL27
Copy link
Collaborator Author

HenryL27 commented Nov 3, 2023

Gonna implement this as a new ml-algorithm / function name: TEXT_SIMILARITY. Cross-encoders are one technique to do this, but not the only one. Essentially it's just defined as (text1, text2) -> similarity_socre
(As opposed to embedding models which are (text) -> vector, and then similarity is an inner product of two vectors)

@HenryL27
Copy link
Collaborator Author

HenryL27 commented Nov 6, 2023

A bunch of requests have come in for remote reranking models too, so I'll make sure that connectors can deal with TextSimilarityDatasets appropriately as well

@ylwu-amzn
Copy link
Collaborator

Make sure local model and remote model can be switched smoothly .

@ylwu-amzn
Copy link
Collaborator

Make sure local model and remote model can be switched smoothly .

This is done in this PR #1954

@ylwu-amzn ylwu-amzn added the v2.12.0 Issues targeting release v2.12.0 label Feb 3, 2024
@dhrubo-os
Copy link
Collaborator

Make sure local model and remote model can be switched smoothly .

@HenryL27 will check remote model and then we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.12.0 Issues targeting release v2.12.0
Projects
Status: 2.12.0 (Launched)
Status: In Progress
Development

No branches or pull requests

4 participants