Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL] Refactor useFetcher with data source id #316

Open
wanglam opened this issue Apr 19, 2024 · 0 comments
Open

[PROPOSAL] Refactor useFetcher with data source id #316

wanglam opened this issue Apr 19, 2024 · 0 comments

Comments

@wanglam
Copy link
Collaborator

wanglam commented Apr 19, 2024

What/Why

What are you proposing?

This issue is for proposing refactor useFetcher can be automatic reload after data source id change.

What users have asked for this feature?

#315

What problems are you trying to solve?

After this refactor, we don't need to pass data source id from the page component side. It will be filled in the API side and automatic reload when using useFetcher after data source id change.

Any remaining open questions?

Sometimes, the params in useFetcher will be changed immediately when data source changed. It will send two requests, it is unnecessary. The useFetcher need to cancel previous request first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant