Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport-2.x] Added user level access control based on backend roles (#838) #847

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

owaiskazi19
Copy link
Member

@owaiskazi19 owaiskazi19 commented Aug 26, 2024

Backport of #838

Signed-off-by: owaiskazi19 [email protected]
Signed-off-by: Owais [email protected]
(cherry picked from commit 60458a6)

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…oject#838)

* Implemented backend role filtering for Flow Framework

Signed-off-by: owaiskazi19 <[email protected]>

* Spotless Fixes

Signed-off-by: owaiskazi19 <[email protected]>

* Added secured integ tests

Signed-off-by: owaiskazi19 <[email protected]>

* Fixed threadcontext and an integ test

Signed-off-by: owaiskazi19 <[email protected]>

* Added javadocs and fixed checkstyle

Signed-off-by: owaiskazi19 <[email protected]>

* Added backend role filtering for reprovisioning API

Signed-off-by: owaiskazi19 <[email protected]>

* Fixed exceptions

Signed-off-by: owaiskazi19 <[email protected]>

* Updated CHANGELOG

Signed-off-by: owaiskazi19 <[email protected]>

* Fixed forbidden APIs in tests

Signed-off-by: owaiskazi19 <[email protected]>

* Added secured integ tests for reprovision workflow

Signed-off-by: owaiskazi19 <[email protected]>

* Fixed checkstyle violation

Signed-off-by: owaiskazi19 <[email protected]>

* Added more tests and resolved PR comments

Signed-off-by: Owais <[email protected]>

* Addressed additional PR Comments

Signed-off-by: Owais <[email protected]>

* Updated the javadoc

Signed-off-by: Owais <[email protected]>

---------

Signed-off-by: owaiskazi19 <[email protected]>
Signed-off-by: Owais <[email protected]>
(cherry picked from commit 60458a6)
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 71.95767% with 106 lines in your changes missing coverage. Please review.

Project coverage is 77.44%. Comparing base (f032867) to head (a20b569).
Report is 1 commits behind head on 2.x.

Files Patch % Lines
.../org/opensearch/flowframework/util/ParseUtils.java 58.66% 26 Missing and 5 partials ⚠️
...rk/transport/ProvisionWorkflowTransportAction.java 66.66% 20 Missing and 3 partials ⚠️
.../transport/ReprovisionWorkflowTransportAction.java 79.68% 12 Missing and 1 partial ⚠️
...ework/transport/CreateWorkflowTransportAction.java 70.00% 8 Missing and 1 partial ⚠️
...ork/transport/GetWorkflowStateTransportAction.java 78.57% 5 Missing and 1 partial ⚠️
...ework/transport/DeleteWorkflowTransportAction.java 75.00% 5 Missing ⚠️
...ramework/transport/GetWorkflowTransportAction.java 80.76% 4 Missing and 1 partial ⚠️
.../transport/DeprovisionWorkflowTransportAction.java 83.33% 4 Missing ⚠️
...flowframework/transport/handler/SearchHandler.java 84.61% 3 Missing and 1 partial ⚠️
.../transport/SearchWorkflowStateTransportAction.java 40.00% 3 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #847      +/-   ##
============================================
- Coverage     77.54%   77.44%   -0.10%     
- Complexity      928      963      +35     
============================================
  Files            96       97       +1     
  Lines          4359     4536     +177     
  Branches        413      423      +10     
============================================
+ Hits           3380     3513     +133     
- Misses          806      841      +35     
- Partials        173      182       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis dbwiddis merged commit dad8d31 into opensearch-project:2.x Aug 26, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants