Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Add allow_delete parameter to Deprovision API (#763) #785

Merged
merged 1 commit into from
Jul 16, 2024
Merged

[Backport 2.x] Add allow_delete parameter to Deprovision API (#763) #785

merged 1 commit into from
Jul 16, 2024

Conversation

dbwiddis
Copy link
Member

Backport 7e7e993 from #763.

@dbwiddis
Add allow_delete parameter to Deprovision API (opensearch-project#763)
ef83047 
* Add allow_delete parameter to Deprovision API

* Add denylist for workflow step types users are not allowed to use

Signed-off-by: Daniel Widdis <[email protected]>

* Remove denylisted steps from GetWorkflowStep response

Signed-off-by: Daniel Widdis <[email protected]>

* Remove mention of new steps from change log

Signed-off-by: Daniel Widdis <[email protected]>

---------

Signed-off-by: Daniel Widdis <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 93.08176% with 11 lines in your changes missing coverage. Please review.

Project coverage is 75.33%. Comparing base (7dec529) to head (ef83047).

Files Patch % Lines
...search/flowframework/workflow/DeleteIndexStep.java 89.65% 2 Missing and 1 partial ⚠️
...owframework/workflow/DeleteIngestPipelineStep.java 89.65% 2 Missing and 1 partial ⚠️
...owframework/workflow/DeleteSearchPipelineStep.java 89.65% 2 Missing and 1 partial ⚠️
...wframework/rest/RestDeprovisionWorkflowAction.java 66.66% 0 Missing and 1 partial ⚠️
...pensearch/flowframework/workflow/WorkflowStep.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x     #785      +/-   ##
============================================
+ Coverage     74.61%   75.33%   +0.71%     
- Complexity      783      816      +33     
============================================
  Files            84       88       +4     
  Lines          3873     3998     +125     
  Branches        356      362       +6     
============================================
+ Hits           2890     3012     +122     
- Misses          825      829       +4     
+ Partials        158      157       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis dbwiddis merged commit 4358929 into opensearch-project:2.x Jul 16, 2024
30 of 31 checks passed
@dbwiddis dbwiddis deleted the backport/backport-763-to-2.x branch July 16, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owaiskazi19 owaiskazi19 owaiskazi19 approved these changes

@joshpalis joshpalis Awaiting requested review from joshpalis joshpalis is a code owner

@ohltyler ohltyler Awaiting requested review from ohltyler ohltyler is a code owner

@amitgalitz amitgalitz Awaiting requested review from amitgalitz amitgalitz is a code owner

@jackiehanyang jackiehanyang Awaiting requested review from jackiehanyang jackiehanyang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbwiddis @owaiskazi19