[Backport 2.x] Create a Config XContent model for Config index #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Create a Config XContent model for Config index Signed-off-by: Daniel Widdis <[email protected]> * Move XContent builder into lambda Signed-off-by: Daniel Widdis <[email protected]> * Improve test coverage Signed-off-by: Daniel Widdis <[email protected]> * Even more test coverage Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 40d9efc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #698 +/- ##
============================================
+ Coverage 73.74% 74.56% +0.82%
- Complexity 722 735 +13
============================================
Files 82 83 +1
Lines 3668 3708 +40
Branches 315 318 +3
============================================
+ Hits 2705 2765 +60
+ Misses 820 800 -20
Partials 143 143 ☔ View full report in Codecov by Sentry. |
dbwiddis
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 40d9efc from #679.