[Backport 2.x] Add timeout for node execution #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Add timeout for node execution Signed-off-by: Daniel Widdis <[email protected]> * Properly implement delays using OpenSearch ThreadPool Signed-off-by: Daniel Widdis <[email protected]> * Add coverage for plugin class, make test threshold dynamic Signed-off-by: Daniel Widdis <[email protected]> * Tests don't like singletons Signed-off-by: Daniel Widdis <[email protected]> * More thorough ProcessNode testing Signed-off-by: Daniel Widdis <[email protected]> * Util method for timeout parsing Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 28326bd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #69 +/- ##
============================================
+ Coverage 86.93% 91.68% +4.74%
- Complexity 163 167 +4
============================================
Files 13 13
Lines 574 565 -9
Branches 75 78 +3
============================================
+ Hits 499 518 +19
+ Misses 52 24 -28
Partials 23 23
|
|
dbwiddis
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 28326bd from #66.