Create a Config XContent model for Config index #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
dbwiddis
force-pushed
the
config
branch
2 times, most recently
from
14372a4
to
4db3fa4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #679 +/- ##
============================================
+ Coverage 72.56% 73.44% +0.87%
- Complexity 697 710 +13
============================================
Files 82 83 +1
Lines 3605 3645 +40
Branches 309 312 +3
============================================
+ Hits 2616 2677 +61
+ Misses 845 823 -22
- Partials 144 145 +1 ☔ View full report in Codecov by Sentry. |
owaiskazi19
approved these changes
Apr 25, 2024
dbwiddis
force-pushed
the
config
branch
3 times, most recently
from
3818ca6
to
08a29f3
Compare
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
joshpalis
approved these changes
May 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 2, 2024
* Create a Config XContent model for Config index Signed-off-by: Daniel Widdis <[email protected]> * Move XContent builder into lambda Signed-off-by: Daniel Widdis <[email protected]> * Improve test coverage Signed-off-by: Daniel Widdis <[email protected]> * Even more test coverage Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 40d9efc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
May 2, 2024
Create a Config XContent model for Config index (#679) * Create a Config XContent model for Config index * Move XContent builder into lambda * Improve test coverage * Even more test coverage --------- (cherry picked from commit 40d9efc) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates a Java Object abstraction for the key-value maps used for the config index, separating data from code.
Issues Resolved
Resolves #675
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.