Throw the correct error message in status API for WorkflowSteps

[owaiskazi19]

Description

Throw the correct error message in status API for WorkflowSteps. As called out in the issue, exceptions added in getException method are safe exceptions to be shown in status API.

Few examples:

{
    "workflow_id": "y_KgDY8BnN13dc10B7Lw",
    "error": "Missing credential during step create_claude_connector, restStatus: BAD_REQUEST",
    "state": "FAILED"
}

{
    "workflow_id": "MrGqDY8BlF2RpBCvbloe",
    "error": "No processor type exists with name [text_embeddinsg] during step create_ingest_pipeline, restStatus: BAD_REQUEST",
    "state": "FAILED"
}

Issues Resolved

Resolves #670

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

Attention: Patch coverage is 57.57576% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 72.64%. Comparing base (757eaaf) to head (2a77791).

Files	Patch %	Lines
...flowframework/exception/WorkflowStepException.java	50.00%	0 Missing and 2 partials ⚠️
...rk/transport/ProvisionWorkflowTransportAction.java	0.00%	1 Missing ⚠️
...framework/workflow/AbstractCreatePipelineStep.java	50.00%	0 Missing and 1 partial ⚠️
...ework/workflow/AbstractRegisterLocalModelStep.java	75.00%	0 Missing and 1 partial ⚠️
...ch/flowframework/workflow/CreateConnectorStep.java	50.00%	0 Missing and 1 partial ⚠️
...search/flowframework/workflow/CreateIndexStep.java	75.00%	0 Missing and 1 partial ⚠️
...search/flowframework/workflow/DeleteAgentStep.java	50.00%	0 Missing and 1 partial ⚠️
...ch/flowframework/workflow/DeleteConnectorStep.java	50.00%	0 Missing and 1 partial ⚠️
...search/flowframework/workflow/DeleteModelStep.java	50.00%	0 Missing and 1 partial ⚠️
...search/flowframework/workflow/DeployModelStep.java	50.00%	0 Missing and 1 partial ⚠️
... and 3 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #676      +/-   ##
============================================
- Coverage     72.88%   72.64%   -0.25%     
- Complexity      694      697       +3     
============================================
  Files            82       82              
  Lines          3589     3605      +16     
  Branches        296      309      +13     
============================================
+ Hits           2616     2619       +3     
  Misses          841      841              
- Partials        132      145      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[amitgalitz]

Can you test case of how exception looks like when there is unsafe exception like remotetransportexception, when you deploy multiple models at the same time.

Also can we also add this to create index step, along with changing CreateIndexStep line here to workflowstepexception https://github.com/opensearch-project/flow-framework/blob/main/src/main/java/org/opensearch/flowframework/workflow/CreateIndexStep.java#L142

[owaiskazi19]

Can you test case of how exception looks like when there is unsafe exception like remotetransportexception, when you deploy multiple models at the same time.

Added 2 tests for CreateIndex and RegisterRemoteStep

Also can we also add this to create index step, along with changing CreateIndexStep line here to workflowstepexception https://github.com/opensearch-project/flow-framework/blob/main/src/main/java/org/opensearch/flowframework/workflow/CreateIndexStep.java#L142

Done

[dbwiddis]

LGTM!