Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional delay parameter to no-op step #674

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

dbwiddis
Copy link
Member

Description

Adds an optional delay to the no-op workflow step

Issues Resolved

Fixes #649

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 72.35%. Comparing base (b8e4ed0) to head (6b81dbc).

❗ Current head 6b81dbc differs from pull request most recent head 05787ec. Consider uploading reports for the commit 05787ec to get more accurate results

Files Patch % Lines
...rg/opensearch/flowframework/workflow/NoOpStep.java 81.81% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #674      +/-   ##
============================================
+ Coverage     72.32%   72.35%   +0.02%     
- Complexity      686      687       +1     
============================================
  Files            82       82              
  Lines          3574     3585      +11     
  Branches        294      295       +1     
============================================
+ Hits           2585     2594       +9     
- Misses          857      859       +2     
  Partials        132      132              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@owaiskazi19 owaiskazi19 merged commit bae3aa2 into opensearch-project:main Apr 24, 2024
30 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 24, 2024
Signed-off-by: Daniel Widdis <[email protected]>
(cherry picked from commit bae3aa2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis pushed a commit that referenced this pull request Apr 24, 2024
Add optional delay parameter to no-op step (#674)


(cherry picked from commit bae3aa2)

Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dbwiddis dbwiddis deleted the delay-noop branch June 10, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add optional time delay to no-op step
3 participants