Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Workflow Step for ReIndex #660

Closed
wants to merge 1 commit into from

Conversation

owaiskazi19
Copy link
Member

Description

Added Workflow Step for ReIndex. This workflow step currently support just parameters source and destination index.
Reindex does support other lots of params like here.

More details about the indices, template and response can be found here.

Keeping this in draft mode.

Issues Resolved

#617

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added the backport 2.x backport PRs to 2.x branch label Apr 12, 2024
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 74.47%. Comparing base (e3a8784) to head (0c2e282).

Current head 0c2e282 differs from pull request most recent head bdf614d

Please upload reports for the commit bdf614d to get more accurate results.

Files Patch % Lines
...opensearch/flowframework/workflow/ReIndexStep.java 75.51% 11 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #660      +/-   ##
============================================
+ Coverage     74.44%   74.47%   +0.03%     
- Complexity      738      742       +4     
============================================
  Files            83       84       +1     
  Lines          3741     3793      +52     
  Branches        322      323       +1     
============================================
+ Hits           2785     2825      +40     
- Misses          811      822      +11     
- Partials        145      146       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis
Copy link
Member

@YANG-DB what parameters do you need for your observability use case?

@YANG-DB
Copy link
Member

YANG-DB commented Apr 15, 2024

We need the ability to parameterize for the create index example:

  • index name
  • index alias name
  • index settings

In the case of creating a mapping template example:

  • template name
  • components list

@navneet1v
Copy link

@owaiskazi19 , @minalsha One suggestion I have here is we should add the parameters from re-index api that controls the speed of re-indexing. As per my understanding the parameter that controls is requests_per_second. Reason we should add this in because this step will be used to re-index BM25 data to vectors via ML model. Most of ML models have a limitation on how many request they can handle per sec. So to give better user experience we should have this field atleast.

@owaiskazi19
Copy link
Member Author

Closing in favor of #718.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants