Improve error messages for workflow states other than NOT_STARTED #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #642 +/- ##
============================================
+ Coverage 72.25% 72.30% +0.05%
Complexity 680 680
============================================
Files 82 82
Lines 3528 3528
Branches 284 285 +1
============================================
+ Hits 2549 2551 +2
+ Misses 854 850 -4
- Partials 125 127 +2 ☔ View full report in Codecov by Sentry. |
amitgalitz
reviewed
Apr 2, 2024
src/main/java/org/opensearch/flowframework/transport/ProvisionWorkflowTransportAction.java
Show resolved
Hide resolved
dbwiddis
force-pushed
the
provision-error
branch
from
ff57981
to
deb7b65
Compare
owaiskazi19
reviewed
Apr 3, 2024
src/main/java/org/opensearch/flowframework/transport/ProvisionWorkflowTransportAction.java
Show resolved
Hide resolved
owaiskazi19
approved these changes
Apr 4, 2024
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
force-pushed
the
provision-error
branch
from
9cb611f
to
f6c7810
Compare
joshpalis
approved these changes
Apr 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 6, 2024
* Improve error messages for workflow states other than NOT_STARTED Signed-off-by: Daniel Widdis <[email protected]> * Update CHANGELOG Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 452aec5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Apr 6, 2024
…NOT_STARTED (#653) Improve error messages for workflow states other than NOT_STARTED (#642) * Improve error messages for workflow states other than NOT_STARTED * Update CHANGELOG --------- (cherry picked from commit 452aec5) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves error messages to be more clear that a state of NOT_STARTED is required, and suggests how to reattain that state.
Issues Resolved
Fixes #640
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.