Moves ui-metadata field from state to template index #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Palis <[email protected]>
joshpalis
requested review from
dbwiddis,
owaiskazi19,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
joshpalis
added
skip-changelog
and removed
backport 2.x
owaiskazi19
approved these changes
Apr 2, 2024
|
@owaiskazi19 should I also increment the schema versions of both mappings? This field is not searchable, only used by the front end, so not sure if we would need to |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #636 +/- ##
=========================================
Coverage 72.39% 72.39%
Complexity 684 684
=========================================
Files 82 82
Lines 3535 3535
Branches 288 288
=========================================
Hits 2559 2559
Misses 850 850
Partials 126 126 ☔ View full report in Codecov by Sentry. |
This change will be a part of 2.14 after GA in 2.13, so yes we should increment it. |
Signed-off-by: Joshua Palis <[email protected]>
ohltyler
approved these changes
Apr 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
* moving ui-metadata from state to template index Signed-off-by: Joshua Palis <[email protected]> * incrementing schema versions Signed-off-by: Joshua Palis <[email protected]> --------- Signed-off-by: Joshua Palis <[email protected]> (cherry picked from commit 28cf793) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis
pushed a commit
that referenced
this pull request
Apr 2, 2024
…637) Moves ui-metadata field from state to template index (#636) * moving ui-metadata from state to template index * incrementing schema versions --------- (cherry picked from commit 28cf793) Signed-off-by: Joshua Palis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
Should we add this to the BWC tests? What happens if we read a template from a 2.13 index (that has this field) in 2.14? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the ui-metadata field from the state to template index mapping
Issues Resolved
#140
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.