Name changes to use cases #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitgalitz
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler and
jackiehanyang
as code owners
owaiskazi19
approved these changes
Mar 28, 2024
Signed-off-by: Amit Galitzky <[email protected]>
amitgalitz
force-pushed
the
name-changes
branch
from
ab2381b
to
b6dcbf7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #625 +/- ##
=========================================
Coverage 72.39% 72.39%
Complexity 684 684
=========================================
Files 82 82
Lines 3535 3535
Branches 288 288
=========================================
Hits 2559 2559
Misses 850 850
Partials 126 126 ☔ View full report in Codecov by Sentry. |
joshpalis
approved these changes
Mar 28, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
use case name changes Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 42f53da) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amitgalitz
added a commit
to amitgalitz/opensearch-ai-flow-framework
that referenced
this pull request
Mar 28, 2024
use case name changes Signed-off-by: Amit Galitzky <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
use case name changes Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 42f53da) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Mar 28, 2024
Name changes to use cases (#625) use case name changes Signed-off-by: Amit Galitzky <[email protected]>
owaiskazi19
pushed a commit
that referenced
this pull request
Mar 28, 2024
Name changes to use cases (#625) use case name changes (cherry picked from commit 42f53da) Signed-off-by: Amit Galitzky <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
changing all use case names to have underscore and also adding distinct default file for semantic_search_with_cohere_embedding_query_enricher instead of using same one as without query_enricher based on tech writer suggestion.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.