[POC] Added Predict and SearchRequest workflow step #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owaiskazi19
requested review from
dbwiddis,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
joshpalis
reviewed
Mar 27, 2024
src/main/java/org/opensearch/flowframework/workflow/SearchRequestStep.java
Outdated
Show resolved
Hide resolved
owaiskazi19
force-pushed
the
predict-api
branch
2 times, most recently
from
f7d33bf
to
89b6b97
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature-poc #621 +/- ##
=================================================
- Coverage 72.75% 71.14% -1.62%
Complexity 681 681
=================================================
Files 82 84 +2
Lines 3491 3580 +89
Branches 279 282 +3
=================================================
+ Hits 2540 2547 +7
- Misses 832 914 +82
Partials 119 119 ☔ View full report in Codecov by Sentry. |
owaiskazi19
force-pushed
the
predict-api
branch
from
89b6b97
to
a7323d8
Compare
joshpalis
approved these changes
Mar 27, 2024
src/main/java/org/opensearch/flowframework/workflow/WorkflowStepFactory.java
Outdated
Show resolved
Hide resolved
owaiskazi19
force-pushed
the
predict-api
branch
from
a7323d8
to
48942fd
Compare
joshpalis
reviewed
Mar 27, 2024
src/main/java/org/opensearch/flowframework/workflow/WorkflowStepFactory.java
Outdated
Show resolved
Hide resolved
owaiskazi19
force-pushed
the
predict-api
branch
from
48942fd
to
d803413
Compare
Signed-off-by: Owais Kazi <[email protected]>
owaiskazi19
force-pushed
the
predict-api
branch
from
d803413
to
4a2d752
Compare
amitgalitz
approved these changes
Mar 28, 2024
amitgalitz
merged commit 4de0d99
into
opensearch-project:feature-poc
30 of 31 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe what this change achieves.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.