Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing register agent tests #595

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Conversation

joshpalis
Copy link
Member

Description

Fixes register agent tests failing due to opensearch-project/ml-commons#2204

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.75%. Comparing base (aa8a454) to head (e991a40).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #595   +/-   ##
=========================================
  Coverage     72.75%   72.75%           
  Complexity      681      681           
=========================================
  Files            82       82           
  Lines          3491     3491           
  Branches        279      279           
=========================================
  Hits           2540     2540           
  Misses          832      832           
  Partials        119      119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshpalis joshpalis mentioned this pull request Mar 19, 2024
@joshpalis
Copy link
Member Author

joshpalis commented Mar 19, 2024

Seeing some failures in integration tests, seems its an issue with the ML Indices handler being unable to create the ml model index

» ERROR][o.o.m.e.i.MLIndicesHandler] [integTest-0] Failed to create index .plugins-ml-model
»  com.fasterxml.jackson.core.JsonParseException: Unexpected character ('}' (code 125)): was expecting double-quote to start field name
»   at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 54, column: 1]
»  	at com.fasterxml.jackson.core.JsonParser._constructReadException(JsonParser.java:2643) ~[jackson-core-2.17.0.jar:2.17.0]
»  	at com.fasterxml.jackson.core.base.ParserMinimalBase._reportUnexpectedChar(ParserMinimalBase.java:685) ~[jackson-core-2.17.0.jar:2.17.0]
»  	at com.fasterxml.jackson.core.json.ReaderBasedJsonParser._handleOddName(ReaderBasedJsonParser.java:1910) ~[jackson-core-2.17.0.jar:2.17.0]
»  	at com.fasterxml.jackson.core.json.ReaderBasedJsonParser.nextToken(ReaderBasedJsonParser.java:709) ~[jackson-core-2.17.0.jar:2.17.0]
»  	at org.opensearch.common.xcontent.json.JsonXContentParser.nextToken(JsonXContentParser.java:66) ~[opensearch-x-content-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]

@dbwiddis
Copy link
Member

Unexpected character ('}' (code 125)): was expecting double-quote to start field name

Are we missing a mandatory field when creating the model? CC: @dhrubo-os

@dbwiddis
Copy link
Member

@joshpalis joshpalis force-pushed the fix-agent branch 5 times, most recently from a713c69 to d90e86f Compare March 19, 2024 21:50
Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: Joshua Palis <[email protected]>
@dhrubo-os
Copy link

Unexpected character ('}' (code 125)): was expecting double-quote to start field name

Are we missing a mandatory field when creating the model? CC: @dhrubo-os

We fixed the bug now: opensearch-project/ml-commons#2234

Signed-off-by: Joshua Palis <[email protected]>
@joshpalis joshpalis merged commit ebcc8f7 into opensearch-project:main Mar 20, 2024
32 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 20, 2024
* Fixing register agent tests

Signed-off-by: Joshua Palis <[email protected]>

* fixing register agent IT

Signed-off-by: Joshua Palis <[email protected]>

* Fixing agent type

Signed-off-by: Joshua Palis <[email protected]>

---------

Signed-off-by: Joshua Palis <[email protected]>
(cherry picked from commit ebcc8f7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 20, 2024
* Fixing register agent tests

Signed-off-by: Joshua Palis <[email protected]>

* fixing register agent IT

Signed-off-by: Joshua Palis <[email protected]>

* Fixing agent type

Signed-off-by: Joshua Palis <[email protected]>

---------

Signed-off-by: Joshua Palis <[email protected]>
(cherry picked from commit ebcc8f7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis pushed a commit that referenced this pull request Mar 20, 2024
Fixing register agent tests (#595)

* Fixing register agent tests



* fixing register agent IT



* Fixing agent type



---------


(cherry picked from commit ebcc8f7)

Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis pushed a commit that referenced this pull request Mar 20, 2024
Fixing register agent tests (#595)

* Fixing register agent tests



* fixing register agent IT



* Fixing agent type



---------


(cherry picked from commit ebcc8f7)

Signed-off-by: Joshua Palis <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants