Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug passing params to workflows #559

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

dbwiddis
Copy link
Member

Description

Fixes two bugs with parameter substitution:

  • Method arguments for previous node inputs and user params were swapped when executing workflows. This wasn't obvious because of a "catch all" fallback when previous node inputs isn't included, that got them anyway
  • When provisioning via create workflow REST API, the new workflow request didn't pass along the params map

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.91%. Comparing base (2707210) to head (731f244).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #559      +/-   ##
============================================
+ Coverage     72.81%   72.91%   +0.09%     
  Complexity      675      675              
============================================
  Files            79       79              
  Lines          3451     3452       +1     
  Branches        273      273              
============================================
+ Hits           2513     2517       +4     
+ Misses          822      818       -4     
- Partials        116      117       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis dbwiddis merged commit 4bf6e32 into opensearch-project:main Mar 11, 2024
34 of 40 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 11, 2024
Signed-off-by: Daniel Widdis <[email protected]>
(cherry picked from commit 4bf6e32)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dbwiddis dbwiddis deleted the bugfix branch March 11, 2024 17:37
dbwiddis pushed a commit that referenced this pull request Mar 11, 2024
Fix bug passing params to workflows (#559)


(cherry picked from commit 4bf6e32)

Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants