Ensure params are consumed before checking feature flag #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
added
backport 2.x
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #514 +/- ##
============================================
+ Coverage 72.01% 72.10% +0.09%
Complexity 624 624
============================================
Files 78 78
Lines 3162 3162
Branches 239 239
============================================
+ Hits 2277 2280 +3
+ Misses 780 777 -3
Partials 105 105 ☔ View full report in Codecov by Sentry. |
joshpalis
approved these changes
Feb 9, 2024
owaiskazi19
approved these changes
Feb 9, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 9, 2024
Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 1727434) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 9, 2024
Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 1727434) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Feb 9, 2024
#516) Ensure params are consumed before checking feature flag (#514) (cherry picked from commit 1727434) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis
pushed a commit
that referenced
this pull request
Feb 10, 2024
…ag (#517) Ensure params are consumed before checking feature flag (#514) (cherry picked from commit 1727434) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Consumes params by assigning them before feature flag check, to prevent confusing error messages.
Issues Resolved
Fixes #513
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.