Retry flaky tests #449
Merged
Retry flaky tests #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owais Kazi <[email protected]>
owaiskazi19
force-pushed
the
retry-tests
branch
from
30bf56f
to
55ba20a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #449 +/- ##
=========================================
Coverage 71.88% 71.88%
Complexity 620 620
=========================================
Files 78 78
Lines 3126 3126
Branches 236 236
=========================================
Hits 2247 2247
Misses 772 772
Partials 107 107 ☔ View full report in Codecov by Sentry. |
dbwiddis
reviewed
Jan 24, 2024
dbwiddis
reviewed
Jan 24, 2024
dbwiddis
reviewed
Jan 24, 2024
owaiskazi19
requested review from
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
owaiskazi19
added
backport 2.x
owaiskazi19
force-pushed
the
retry-tests
branch
from
a58a156
to
6bb345c
Compare
joshpalis
approved these changes
Jan 24, 2024
joshpalis
approved these changes
Jan 24, 2024
dbwiddis
approved these changes
Jan 24, 2024
|
looks good to me, but I agree with Josh that we need another issue to solve these failures, the multi node flakiness is still a little concerning |
amitgalitz
approved these changes
Jan 24, 2024
Signed-off-by: Owais Kazi <[email protected]>
owaiskazi19
force-pushed
the
retry-tests
branch
from
6bb345c
to
5843aec
Compare
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 25, 2024
* Retry flaky tests Signed-off-by: Owais Kazi <[email protected]> * Addressed PR Comments Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]> (cherry picked from commit 03cdb99) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
owaiskazi19
pushed a commit
that referenced
this pull request
Jan 25, 2024
Retry flaky tests (#449) * Retry flaky tests * Addressed PR Comments --------- (cherry picked from commit 03cdb99) Signed-off-by: Owais Kazi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Retry flaky tests using
org.gradle.test-retryplugin.Issues Resolved
Closes #442
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.