Fix process node zero timeout and handle not found exceptions #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #411 +/- ##
============================================
- Coverage 71.95% 71.83% -0.13%
Complexity 613 613
============================================
Files 79 79
Lines 3081 3082 +1
Branches 238 237 -1
============================================
- Hits 2217 2214 -3
- Misses 760 763 +3
- Partials 104 105 +1 ☔ View full report in Codecov by Sentry. |
|
Thanks for making this fix! Been trying to look at it for a while with no luck finding root cause. I was wondering if you understood why this was happening only on multi node consistently |
amitgalitz
approved these changes
Jan 17, 2024
owaiskazi19
approved these changes
Jan 17, 2024
owaiskazi19
reviewed
Jan 17, 2024
src/main/java/org/opensearch/flowframework/transport/DeprovisionWorkflowTransportAction.java
Show resolved
Hide resolved
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 17, 2024
Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit c6e6ed2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
owaiskazi19
pushed a commit
that referenced
this pull request
Jan 17, 2024
…eptions (#412) Fix process node zero timeout and handle not found exceptions (#411) (cherry picked from commit c6e6ed2) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in deprovisioning where the
ProcessNodehad no timeout and blocked threads.Also handles exceptionally completed futures with an
OpenSearchStatusExceptionwithNOT_FOUNDstatus as successful deprovisions.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.