Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Eliminate Google Guava dependency (#383) #389

Merged
merged 1 commit into from
Jan 9, 2024
Merged

[Backport 2.x] Eliminate Google Guava dependency (#383) #389

merged 1 commit into from
Jan 9, 2024

Conversation

dbwiddis
Copy link
Member

@dbwiddis dbwiddis commented Jan 9, 2024

Backport fea3e6e from #383

@dbwiddis @owaiskazi19
Eliminate Google Guava dependency (opensearch-project#383)
c3030f4 
* Eliminate Google Guava dependency

Signed-off-by: Daniel Widdis <[email protected]>

* Fix classpath

Signed-off-by: Daniel Widdis <[email protected]>

---------

Signed-off-by: Daniel Widdis <[email protected]>
Co-authored-by: Owais Kazi <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (afe5501) 72.52% compared to head (c3030f4) 72.49%.

Files Patch % Lines
.../org/opensearch/flowframework/util/ParseUtils.java 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x     #389      +/-   ##
============================================
- Coverage     72.52%   72.49%   -0.03%     
- Complexity      600      601       +1     
============================================
  Files            76       76              
  Lines          3014     3018       +4     
  Branches        234      235       +1     
============================================
+ Hits           2186     2188       +2     
- Misses          725      726       +1     
- Partials        103      104       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshpalis joshpalis merged commit 9616443 into opensearch-project:2.x Jan 9, 2024
15 checks passed
@dbwiddis dbwiddis deleted the backport/backport-383-to-2.x branch April 15, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshpalis joshpalis joshpalis approved these changes

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@ohltyler ohltyler Awaiting requested review from ohltyler ohltyler is a code owner

@amitgalitz amitgalitz Awaiting requested review from amitgalitz amitgalitz is a code owner

@jackiehanyang jackiehanyang Awaiting requested review from jackiehanyang jackiehanyang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbwiddis @joshpalis