Change max retries to retry duration, refactor settings for consistency #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #381 +/- ##
============================================
+ Coverage 72.49% 72.80% +0.30%
- Complexity 601 602 +1
============================================
Files 76 75 -1
Lines 3018 3008 -10
Branches 235 234 -1
============================================
+ Hits 2188 2190 +2
+ Misses 726 716 -10
+ Partials 104 102 -2 ☔ View full report in Codecov by Sentry. |
dbwiddis
changed the title
dbwiddis
force-pushed
the
retry-settings
branch
from
628d882
to
0e7e03c
Compare
dbwiddis
changed the title
dbwiddis
force-pushed
the
retry-settings
branch
2 times, most recently
from
50733ed
to
ad2a989
Compare
owaiskazi19
reviewed
Jan 8, 2024
src/main/java/org/opensearch/flowframework/common/FlowFrameworkSettings.java
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/AbstractRetryableWorkflowStep.java
Show resolved
Hide resolved
owaiskazi19
approved these changes
Jan 8, 2024
amitgalitz
reviewed
Jan 8, 2024
src/main/java/org/opensearch/flowframework/workflow/AbstractRetryableWorkflowStep.java
Show resolved
Hide resolved
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
force-pushed
the
retry-settings
branch
from
ad2a989
to
eafefd4
Compare
joshpalis
approved these changes
Jan 9, 2024
amitgalitz
approved these changes
Jan 9, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
…cy (#381) * Change max retries to retry duration Signed-off-by: Daniel Widdis <[email protected]> * Move max workflows setting update consumer to settings class Signed-off-by: Daniel Widdis <[email protected]> * Move workflow timeout setting update consumer to settings class Signed-off-by: Daniel Widdis <[email protected]> * Use timeout in other search requests Signed-off-by: Daniel Widdis <[email protected]> * Improve test coverage Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit a6fb532) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Jan 9, 2024
…s for consistency (#390) Change max retries to retry duration, refactor settings for consistency (#381) * Change max retries to retry duration * Move max workflows setting update consumer to settings class * Move workflow timeout setting update consumer to settings class * Use timeout in other search requests * Improve test coverage --------- (cherry picked from commit a6fb532) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis
pushed a commit
to joshpalis/opensearch-ai-flow-framework
that referenced
this pull request
Jan 12, 2024
…s for consistency (opensearch-project#390) Change max retries to retry duration, refactor settings for consistency (opensearch-project#381) * Change max retries to retry duration * Move max workflows setting update consumer to settings class * Move workflow timeout setting update consumer to settings class * Use timeout in other search requests * Improve test coverage --------- (cherry picked from commit a6fb532) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Fixes #330
Fixes #338
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.