[Backport 2.x] Iterate collection for unregistered Writeable in streams #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Iterate collection for unregistered Writeable in streams Signed-off-by: Daniel Widdis <[email protected]> * Add dependencies so User class compiles Signed-off-by: Daniel Widdis <[email protected]> * Make ResourceCreated writable for Script class Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 8216cb9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #362 +/- ##
============================================
+ Coverage 71.41% 72.52% +1.10%
- Complexity 562 570 +8
============================================
Files 73 73
Lines 3016 2984 -32
Branches 229 226 -3
============================================
+ Hits 2154 2164 +10
+ Misses 752 716 -36
+ Partials 110 104 -6 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 8216cb9 from #359.