Added a common settings class to initialize plugin settings #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owais Kazi <[email protected]> Signed-off-by: owaiskazi19 <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]> Signed-off-by: owaiskazi19 <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: owaiskazi19 <[email protected]>
owaiskazi19
requested review from
dbwiddis,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
============================================
+ Coverage 72.52% 72.55% +0.03%
- Complexity 570 572 +2
============================================
Files 73 72 -1
Lines 2984 2988 +4
Branches 226 226
============================================
+ Hits 2164 2168 +4
Misses 716 716
Partials 104 104 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Owais Kazi <[email protected]>
joshpalis
approved these changes
Jan 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 5, 2024
* Moved settings to a common singleton class Signed-off-by: Owais Kazi <[email protected]> Signed-off-by: owaiskazi19 <[email protected]> * Removed update retry settings Signed-off-by: Owais Kazi <[email protected]> * Used getter for maxRetry value Signed-off-by: Owais Kazi <[email protected]> Signed-off-by: owaiskazi19 <[email protected]> * Removed FeatureEnabledSettings file Signed-off-by: Owais Kazi <[email protected]> * Fixed tests Signed-off-by: owaiskazi19 <[email protected]> * Moved max workflow step setting to common class Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]> Signed-off-by: owaiskazi19 <[email protected]> (cherry picked from commit a8e7ff5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Jan 5, 2024
…tings (#370) Added a common settings class to initialize plugin settings (#361) * Moved settings to a common singleton class * Removed update retry settings * Used getter for maxRetry value * Removed FeatureEnabledSettings file * Fixed tests * Moved max workflow step setting to common class --------- (cherry picked from commit a8e7ff5) Signed-off-by: Owais Kazi <[email protected]> Signed-off-by: owaiskazi19 <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR achieves the below:
Note: Settings used in Rest classes works well as initialized by the REST call.
Testing:
Issues Resolved
Fixes #351
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.