Remove delete backport branch GitHub Action #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
============================================
- Coverage 71.47% 71.34% -0.14%
+ Complexity 562 561 -1
============================================
Files 73 73
Lines 3001 3001
Branches 230 230
============================================
- Hits 2145 2141 -4
- Misses 746 751 +5
+ Partials 110 109 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
force-pushed
the
no-delete-backport
branch
from
f1b48ba
to
c5b8bec
Compare
owaiskazi19
approved these changes
Jan 3, 2024
amitgalitz
approved these changes
Jan 3, 2024
ohltyler
approved these changes
Jan 3, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 3, 2024
Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit e7b778c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Jan 3, 2024
Remove delete backport branch GitHub Action (#348) (cherry picked from commit e7b778c) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our repo now has a setting toggled that automatically deletes the PR branch when it's merged. This is a native GitHub setting that did not exist when the delete-branch GHA was implemented and should probably be used org-wide.
In any case, this workflow is now useless and will always fail, see for example https://github.com/opensearch-project/flow-framework/actions/runs/7390615156
If you really want your fork branch back after your PR is merged you can always re-open it from the PR dialog.
Issues Resolved
No more emails of failed backport branch deletions when someone deletes their own branch right after merging. 😁
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.