Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Support deploy=true on RegisterRemoteModelStep #342

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link

Backport a45b38c from #340.

* Support deploy=true on RegisterRemoteModelStep

Signed-off-by: Daniel Widdis <[email protected]>

* Hardcode function_name to remote

Signed-off-by: Daniel Widdis <[email protected]>

---------

Signed-off-by: Daniel Widdis <[email protected]>
(cherry picked from commit a45b38c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (43fa96e) 71.70% compared to head (1c49942) 71.65%.

Files Patch % Lines
...lowframework/workflow/RegisterRemoteModelStep.java 73.46% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #342      +/-   ##
============================================
- Coverage     71.70%   71.65%   -0.05%     
- Complexity      560      561       +1     
============================================
  Files            73       73              
  Lines          2962     2978      +16     
  Branches        224      226       +2     
============================================
+ Hits           2124     2134      +10     
- Misses          732      738       +6     
  Partials        106      106              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis dbwiddis merged commit 8cc44ed into 2.x Dec 29, 2023
15 checks passed
@github-actions github-actions bot deleted the backport/backport-340-to-2.x branch December 29, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant