Support deploy=true on RegisterRemoteModelStep #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #340 +/- ##
============================================
- Coverage 71.70% 71.65% -0.05%
- Complexity 560 561 +1
============================================
Files 73 73
Lines 2962 2978 +16
Branches 224 226 +2
============================================
+ Hits 2124 2134 +10
- Misses 732 738 +6
Partials 106 106 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Daniel Widdis <[email protected]>
ohltyler
approved these changes
Dec 29, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 29, 2023
* Support deploy=true on RegisterRemoteModelStep Signed-off-by: Daniel Widdis <[email protected]> * Hardcode function_name to remote Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit a45b38c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Dec 29, 2023
Support deploy=true on RegisterRemoteModelStep (#340) * Support deploy=true on RegisterRemoteModelStep * Hardcode function_name to remote --------- (cherry picked from commit a45b38c) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supports
deploy=truein the RegisterRemoteModelStep. Passes the argument to ML Commons API and updates the resources created to simulate the DeployModelStep having been called.Additionally fixes a bug where a user could add a function name other than "remote" which would always fail.
Issues Resolved
Resolves #339
Fixes #341
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.