Infer edges from previous node inputs #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
requested review from
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
dbwiddis
force-pushed
the
infer-edges
branch
3 times, most recently
from
32530ac
to
f4a52a5
Compare
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
force-pushed
the
infer-edges
branch
from
f4a52a5
to
2933dab
Compare
owaiskazi19
approved these changes
Dec 28, 2023
ohltyler
approved these changes
Dec 28, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 28, 2023
* Infer edges from previous node inputs Signed-off-by: Daniel Widdis <[email protected]> * Fix integ test to make sure we get proper error Signed-off-by: Daniel Widdis <[email protected]> --------- Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit 0855f8f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Dec 28, 2023
Infer edges from previous node inputs (#334) * Infer edges from previous node inputs * Fix integ test to make sure we get proper error --------- (cherry picked from commit 0855f8f) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the
previous_node_inputssection requires input from a previous node, infers that the edge exists even if it hasn't been explicitly defined.Issues Resolved
Fixes #333
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.